docs: add Azure Blob service principal authentication#2592
Conversation
Signed-off-by: Cheruvu.Sahithee.Vaibhav@ibm.com <Cheruvu.Sahithee.Vaibhav@ibm.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe Azure Blob connector documentation now includes ChangesService Principal Authentication Support
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pipeline/outputs/azure_blob.md`:
- Line 163: Update the Azure Blob auth paragraph to explicitly require TLS when
using service principal credentials: state that when auth_type is set to
service_principal (and tenant_id, client_id, client_secret are provided) the tls
setting must be on/true to ensure secure communication; modify the sentence that
currently only shows the example so it unambiguously enforces tls=on for service
principal auth.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8036ab68-a151-439d-b8aa-cc6ae073ab6f
📒 Files selected for processing (1)
pipeline/outputs/azure_blob.md
|
Please resolve the DCO issue as that is a hard requirement for merge. |
|
@Vaibhav-C-S thanks for the docs PR for your matching code changes. As you can see it failed on DCO which is at least one commit not signed. If you open the DCO error with the 3 dots on the right, you can see how to fix this. On top of that you have some other AI suggestions you need to address. All this needs to happen before we can review this PR. |
Signed-off-by: Cheruvu.Sahithee.Vaibhav@ibm.com <Cheruvu.Sahithee.Vaibhav@ibm.com>
9c4fc45 to
373748e
Compare
|
@eschabell @patrick-stephens I have addressed the dco issue |
Signed-off-by: Cheruvu.Sahithee.Vaibhav@ibm.com <Cheruvu.Sahithee.Vaibhav@ibm.com>
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
@Vaibhav-C-S resolved the conflicts first, now working on the vale / lint issues and will review after that. |
… Vale suggestions - Backtick `Entra` in Microsoft Entra ID references - Backtick `codec` in compress_blob description Applies to fluent#2592 Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
@coderabbitai review |
✅ Action performedReview finished.
|
eschabell
left a comment
There was a problem hiding this comment.
@Vaibhav-C-S all good now, thanks for the docs PR! Waiting only on code PR merging.
|
@eschabell Thank you for the help and for the review! I really appreciate it. |
This PR documents service principal authentication support for the Azure Blob output plugin.
It adds:
service_principalas a supportedauth_typetenant_id,client_id, andclient_secretconfiguration parametersNotes
Service principal authentication requires TLS. The service principal must have permission to write to the target storage account or container, such as the
Storage Blob Data Contributorrole.Summary by CodeRabbit